On 24.08.21 17:43, Jan Kiszka wrote:
> On 23.08.21 15:02, Ralf Ramsauer wrote:
>> When I introduced MMU support for inmates, I forgot to map the memory
>> for LEDs. Fix that by simply mapping it.
>>
>> While at it, move the initalisation of led_reg to the top of the routine
>> where it should actually be - it should be initialised before the timer
>> is armed.
>>
>> The mapper will take care that the address will be huge page aligned,
>> and the size will be aligned to HUGE_PAGE_SIZE, so there's no need to
>> align anything on caller site.
>>
>> Fixes: bca43a784716 ("inmates: arm-common: add MMU support")
>> Signed-off-by: Ralf Ramsauer <[email protected]>
>> ---
>> Only compile-time tested! I currently have no device where i could test
>> it.
>>
>
> Let me check if the Orange Pi exposes this. But I swear I saw it
> blinking since then...
>
Indeed, the mappings of the GIC as well as the UART saved us so far on
the OrangePi Zero, likely also on the very similar BananaPi. Other
boards with other address layouts will benefit from this change, though.
Applied to next.
Thanks,
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/1f552e15-8466-0f06-ac77-9ce716feebe9%40siemens.com.
