> Subject: Re: [PATCH 2/2] Kbuild: use toolchain stdarg.h
> 
> On 17.09.21 09:46, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Linux Kernel has shipped a in-house stdarg.h under include/linux/ and
> > drop using the header files with -isystem.
> >
> > However jailhouse need to support multiple kernel versions, instead to
> > add Kernel version check in various source files, update to still use
> > toolchain stdarg.h with -isystem option.
> >
> 
> Also here: 5.15+?
> 
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> >  Kbuild | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Kbuild b/Kbuild
> > index 2863c121..fecf61f7 100644
> > --- a/Kbuild
> > +++ b/Kbuild
> > @@ -58,6 +58,8 @@ subdir-y := hypervisor configs inmates tools
> >
> >  obj-m := driver/
> >
> > +NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC)
> > +-print-file-name=include)
> > +
> 
> Shouldn't we prepare for phasing this out at some point, i.e. indeed make
> these flags version-dependent? Would be a single point, no?

Kernel put stdarg.h under include/linux/, so if need version check, I suppose
in .h/.c file, need add for all the files include stdarg.h

#if xxx
#include <linux/stdarg.h>
#else
#include <stdarg.h>
#endif

So I choose to use toolchain stdarg.h here.

Regards,
Peng.

> 
> >  # Do not generate files by creating dependencies if we are cleaning
> > up  ifeq ($(filter %/Makefile.clean,$(MAKEFILE_LIST)),)
> >
> >
> 
> Jan
> 
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
> 
> --
> You received this message because you are subscribed to the Google Groups
> "Jailhouse" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups
> .google.com%2Fd%2Fmsgid%2Fjailhouse-dev%2F65d5f035-decd-c602-4a53-4
> ce898b22cfc%2540siemens.com&amp;data=04%7C01%7Cpeng.fan%40nxp.c
> om%7C261550c8b03142546bd108d979cc1ba4%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C637674739818118325%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C1000&amp;sdata=EZRf7CV40nvMYwSyqgMUpTy4Dgl3ZP%2B%
> 2FSFTaAN4%2BlFY%3D&amp;reserved=0.

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/DB6PR0402MB2760C093D4F7223290A0189188A49%40DB6PR0402MB2760.eurprd04.prod.outlook.com.

Reply via email to