On 11/10/22 07:45, Ross Philipson wrote:
>       dt = early_memremap(initial_dtb, map_len);
> +     if (!dt) {
> +             pr_warn("failed to memremap initial dtb\n");
> +             return;
> +     }

Are all of these new pr_warn/err()'s really adding much value?  They all
look pretty generic.  It makes me wonder if we should just spit out a
generic message in early_memremap() and save all the callers the trouble.

Oh, and don't we try to refer to functions() with parenthesis?

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/8e62a029-f2fa-0627-1f71-4850a68ec6b6%40intel.com.

Reply via email to