Hi,
Attached is a patch that gets Cactus compiling with a clean classpath.
Currently, the classpaths of <javac>, <stylebook> and <javadoc> only use
the ${java.class.path} property. They make no use of the variables set
in build.properties. This causes:
- compilation to fail with "junit.framework.* not found" errors.
- javadoc to generate lots of similar junit errors.
- stylebook dies, as xerces.jar and xalan.jar aren't available.
Apart from that, the build system is pretty neat. Using build.properties
files greatly simplifies things.
--Jeff
Index: cactus/build/build-servletapi.xml
===================================================================
RCS file: /home/cvspublic/jakarta-commons/cactus/build/build-servletapi.xml,v
retrieving revision 1.1
diff -u -r1.1 build-servletapi.xml
--- cactus/build/build-servletapi.xml 2001/04/09 11:52:27 1.1
+++ cactus/build/build-servletapi.xml 2001/04/11 12:03:51
@@ -261,6 +261,7 @@
<classpath>
<pathelement path="${java.class.path}"/>
<pathelement location="${servlet.jar}"/>
+ <pathelement location="${junit.jar}"/>
</classpath>
</javac>
@@ -342,6 +343,7 @@
<classpath>
<pathelement path="${java.class.path}"/>
<pathelement location="${servlet.jar}"/>
+ <pathelement location="${junit.jar}"/>
</classpath>
</javadoc>
@@ -394,6 +396,9 @@
<classpath>
<pathelement path="${java.class.path}"/>
+ <pathelement location="${stylebook.jar}"/>
+ <pathelement location="${xerces.jar}"/>
+ <pathelement location="${xalan.jar}"/>
</classpath>
</stylebook>
@@ -607,6 +612,7 @@
<classpath>
<pathelement path="${java.class.path}"/>
+ <pathelement location="${stylebook.jar}"/>
</classpath>
</java>
Index: cactus/build/build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-commons/cactus/build/build.xml,v
retrieving revision 1.2
diff -u -r1.2 build.xml
--- cactus/build/build.xml 2001/04/09 11:59:04 1.2
+++ cactus/build/build.xml 2001/04/11 12:07:19
@@ -397,6 +397,9 @@
<classpath>
<pathelement path="${java.class.path}"/>
+ <pathelement location="${stylebook.jar}"/>
+ <pathelement location="${xerces.jar}"/>
+ <pathelement location="${xalan.jar}"/>
</classpath>
</stylebook>
