Hey Remy,
Are the HttpClient JUnit tests working for you? When I run them, I get an
error:
test:
[junit] Running org.apache.commons.httpclient.TestAll
[junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.33 sec
[junit] Testsuite: org.apache.commons.httpclient.TestAll
[junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.33 sec
[junit]
[junit] Testcase: testMethodsOptions took 0.33 sec
[junit] FAILED
[junit] No HTTP method allowed : result of OPTIONS is incorrect.
[junit] junit.framework.AssertionFailedError: No HTTP method allowed
: resul
t of OPTIONS is incorrect.
[junit] at junit.framework.Assert.fail(Assert.java:144)
[junit] at junit.framework.Assert.assert(Assert.java:19)
[junit] at
org.apache.commons.httpclient.TestMethods.testMethodsOptions(
TestMethods.java:119)
[junit] at java.lang.reflect.Method.invoke(Native Method)
[junit] at junit.framework.TestCase.runTest(TestCase.java:156)
[junit] at junit.framework.TestCase.runBare(TestCase.java:130)
[junit] at
junit.framework.TestResult$1.protect(TestResult.java:100)
[junit] at
junit.framework.TestResult.runProtected(TestResult.java:118)
[junit] at junit.framework.TestResult.run(TestResult.java:103)
[junit] at junit.framework.TestCase.run(TestCase.java:121)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:149)
[junit] at junit.framework.TestSuite.run(TestSuite.java:144)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:149)
[junit] at junit.framework.TestSuite.run(TestSuite.java:144)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.
run(JUnitTestRunner.java:202)
[junit] at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.
main(JUnitTestRunner.java:326)
[junit]
I'm having other problems running the library too, so perhaps there's a
bug somewhere.
- Morgan
On Fri, 27 Apr 2001, Remy Maucherat wrote:
> > On Fri, 27 Apr 2001, Remy Maucherat wrote:
> >
> > > > Hey Costin, hey Remy,
> > > >
> > > > I'd like to join the HttpClient project. I see a couple small changes
> I'd
> > > > like to make right now, and I may also add some JavaDocs as I explore
> the
> > > > library.
> > > >
> > > > One comment: to a newbie such as myself, it's a little unclear what is
> > > > explicitly ties to WebDAV, and what is not. We should definitely
> clarify
> > > > the JavaDocs before release time. Also, for the WebDAV-specific
> stuff, we
> > > > should either remove it, or move it into its own package (probably the
> > > > latter).
> > >
> > > There should be no WebDAV specific stuff, except for the status codes,
> but I
> > > think it's a good idea to leave them in.
> > >
> > > Remy
> >
> > I haven't dug into the library far enough yet, but there are lots of
> > JavaDoc comments like "Send a WebDAV request." (at
> > HttpClient.sendRequestBody(HttpMethod,byte[]) that will need to come out
> > if they are not truly WebDAV specific. And anything WebDAV specific
> > should definitely go into a subpackage if possible.
>
> Oops. Some Javadocs need an update apparently ;)
>
> > I'll go ahead and add my name to the status file for HttpClient. My
> > initial contributions won't be very controversial.
>
> Cool :-)
>
> Do you mean you plan to do some serious damage after that ?
> ;-)
>
> Remy
>
>
