i'm sad to say that the DigesterTestCase patch contained a mistake - i 
didn't set the digester property on newly created Rules. this does not 
effect the functionality of the patch (it works fine and i guess that's 
the reason why i missed it).

on the other hand, i'd say that it makes a lot of sense for Digester to 
setDigester(this) on the Rules  in setRules. here's a patch that does this.
  if this patch is acceptable then it means that the other patch will then 
be correct. otherwise i will resubmit...

- robert

Index: digester/src/java/org/apache/commons/digester/Digester.java
===================================================================
RCS file: 
/home/cvs/jakarta-commons/digester/src/java/org/apache/commons/digester/Digester.java,v
retrieving revision 1.11
diff -u -r1.11 Digester.java
--- digester/src/java/org/apache/commons/digester/Digester.java 2001/08/04 23:46:29    
 1.11
+++ digester/src/java/org/apache/commons/digester/Digester.java 2001/08/07 20:16:51
@@ -427,6 +427,7 @@
     public void setRules(Rules rules) {
 
         this.rules = rules;
+        this.rules.setDigester(this);
 
     }
 

Reply via email to