Please do not depricate setDebug/getDebug, slide WebDAV client depends on it.
I have code ready to make setDebug functional again...
As soon as I get commit access I'll commit it and then the old behaviour will be
restored.
Dirk
[EMAIL PROTECTED] wrote:
> rwaldhoff 01/08/08 12:11:24
>
> Modified: httpclient/src/java/org/apache/commons/httpclient
> HttpClient.java HttpMethod.java HttpMethodBase.java
> Log:
> deprecated setDebug, getDebug, etc.
>
> Revision Changes Path
> 1.29 +6 -4
>jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpClient.java
>
> Index: HttpClient.java
> ===================================================================
> RCS file:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpClient.java,v
> retrieving revision 1.28
> retrieving revision 1.29
> diff -u -r1.28 -r1.29
> --- HttpClient.java 2001/08/08 19:01:18 1.28
> +++ HttpClient.java 2001/08/08 19:11:24 1.29
> @@ -1,7 +1,7 @@
> /*
> - * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpClient.java,v
> 1.28 2001/08/08 19:01:18 rwaldhoff Exp $
> - * $Revision: 1.28 $
> - * $Date: 2001/08/08 19:01:18 $
> + * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpClient.java,v
> 1.29 2001/08/08 19:11:24 rwaldhoff Exp $
> + * $Revision: 1.29 $
> + * $Date: 2001/08/08 19:11:24 $
> *
> * ====================================================================
> *
> @@ -229,6 +229,7 @@
>
> /**
> * Debug level.
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> protected int debug = 0;
>
> @@ -284,7 +285,7 @@
>
> /**
> * Set debug level.
> - * @deprecated
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> public void setDebug(int debug) {
> this.debug = debug;
> @@ -293,6 +294,7 @@
>
> /**
> * Get debug level.
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> public int getDebug() {
> return debug;
>
>
>
> 1.5 +6 -5
>jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java
>
> Index: HttpMethod.java
> ===================================================================
> RCS file:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- HttpMethod.java 2001/07/25 06:14:34 1.4
> +++ HttpMethod.java 2001/08/08 19:11:24 1.5
> @@ -1,7 +1,7 @@
> /*
> - * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java,v
> 1.4 2001/07/25 06:14:34 remm Exp $
> - * $Revision: 1.4 $
> - * $Date: 2001/07/25 06:14:34 $
> + * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java,v
> 1.5 2001/08/08 19:11:24 rwaldhoff Exp $
> + * $Revision: 1.5 $
> + * $Date: 2001/08/08 19:11:24 $
> *
> * ====================================================================
> *
> @@ -93,6 +93,7 @@
> * Debug property setter.
> *
> * @param int Debug
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> public void setDebug(int debug);
>
> @@ -235,7 +236,7 @@
>
>
> /**
> - * Ensures the correctness of the request according to criterions which are
> + * Ensures the correctness of the request according to criteria which are
> * method dependent.
> *
> * @return boolean True if the method is valid
> @@ -345,7 +346,7 @@
>
> /**
> * Return true if the method's response is expected to have a body.
> - *
> + *
> * @return true if a response body should be expected by the client
> */
> public boolean hasResponseBody();
>
>
>
> 1.10 +9 -7
>jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java
>
> Index: HttpMethodBase.java
> ===================================================================
> RCS file:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -r1.9 -r1.10
> --- HttpMethodBase.java 2001/07/25 06:14:34 1.9
> +++ HttpMethodBase.java 2001/08/08 19:11:24 1.10
> @@ -1,7 +1,7 @@
> /*
> - * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java,v
> 1.9 2001/07/25 06:14:34 remm Exp $
> - * $Revision: 1.9 $
> - * $Date: 2001/07/25 06:14:34 $
> + * $Header:
>/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java,v
> 1.10 2001/08/08 19:11:24 rwaldhoff Exp $
> + * $Revision: 1.10 $
> + * $Date: 2001/08/08 19:11:24 $
> *
> * ====================================================================
> *
> @@ -91,6 +91,7 @@
>
> /**
> * Debug.
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> protected int debug = 0;
>
> @@ -181,6 +182,7 @@
> * Debug property setter.
> *
> * @param int Debug
> + * @deprecated See {@link org.apache.commons.httpclient.log}
> */
> public void setDebug(int debug) {
> this.debug = debug;
> @@ -366,7 +368,7 @@
>
>
> /**
> - * Ensures the correctness of the request according to criterions which are
> + * Ensures the correctness of the request according to criteria which are
> * method dependent.
> *
> * @return boolean True if the method is valid
> @@ -533,7 +535,7 @@
> }
> requestString += queryString;
> }
> -
> +
> // append parameters, even if the query string
> // has been set
> if (!parameters.isEmpty()) {
> @@ -595,7 +597,7 @@
> requestString = requestString + "?" + parametersString.toString();
> }
>
> - return (getName() + " http://"; + phost + ":" + pport
> + return (getName() + " http://"; + phost + ":" + pport
> + requestString + " " + PROTOCOL + "\r\n");
>
> }
> @@ -613,7 +615,7 @@
>
> /**
> * Return true if the method's response is expected to have a body.
> - *
> + *
> * @return true if a response body should be expected by the client
> */
> public boolean hasResponseBody() {
>
>
>
