----- Original Message -----
From: "Rodney Waldhoff" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Monday, August 27, 2001 5:57 PM
Subject: RE: [httpclient] unit test suite
> >I don't see any unit test to verify that when the server returns 2
cookies
> >in 2 different HTTP headers it works fine !
>
> Well, there's nothing that tests that directly, but there are several
> related tests:
>
> * TestWebappCookie.testMultiSendCookieGet()
>
(http://cvs.apache.org/viewcvs/jakarta-commons/httpclient/src/test/org/apach
e/commons/httpclient/Attic/TestWebappCookie.java)
> tests mutliple cookies, although it doesn't test two distinct Set-Cookie
> headers directly (it does it indirectly though, since every servlet engine
> I'm aware of will send two headers for two calls to response.addCookie()
My only concern is that the test *must* pass every time it is run, meaning
that if you rely on this container behaviour, we need to define a test
server (or several but well defined). We could even automate deploying the
webapp, start the server and stop the server (I have done that countless
times on Cactus so I could help with this automation).
>
> * TestWebappHeaders.testOverwriteRequestHeader()
>
(http://cvs.apache.org/viewcvs/jakarta-commons/httpclient/src/test/org/apach
e/commons/httpclient/Attic/TestWebappHeaders.java)
> tests submitting multiple request headers with the same name.
>
> I'd welcome adding some (even dozens of) mock-object based tests to the
> suite, but I'd be opposed to removing the existing functional tests, as I
> think they serve a useful purpose as well.
I'm of course +1 to keep all existing functional tests !
-Vincent
