Hi Daniel

I've applied your patch to EnumerationIterator, its now in CVS.

From: "Daniel Rall" <[EMAIL PROTECTED]>
> Implemented EnumerationIterator.remove(), with
> same-line-open-curly-style.  ;P

:-)

> I didn't add accessor for Collection, and question whether either
> EnumerationIterator or IteratorEnumeration should have accessors for
> their wrapped instances, or have parameter-less ctors.  It's not part
> of the Iterator/Enumeration interfaces, and I'm curious why they're
> currently necessary.

You're right they are of questionable value.

Its a kind of habbit of mine - I generally find it useful to make objects
that have both empty constructors and setter methods as well as regular
constructors - then code using them can use either 'real code' or
introspection mechanisms such as Digester. Though for simple adapters like
this, I'm not sure if its worth it.

James


_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com

Reply via email to