Hi Richard,

I've made quite "big" modifications of your lcd_st7036.jal lib, so it's
jallib style guide (JSG) compliant... There were a lot of weird things, such
as capitals instead of lowercase, space between function name and open
parenthesis, indentation, etc... all kind of nit-picking things from JSG...

All those things (except indentation) can be checked and indentified by the
jsg_validator script ("python jsg_validator.py lcd_st7036.jal" would have
given errors). Do you have some troubles running this script. Please let me
know, being able to run this script and check results is important for every
jallib committer.

About indentation, this really is an important point. When correctly
indented, the code is readable, when not, it's a mess. For instance,
lcd_wvalue_dp_line_pos_left_sign procedure is very long, with lots of
imbricated "if" and "for". If not correctly indented, reader will take a
long to figure out the logic the procedure.

The associated sample is also in a mess according to the jsg_validator. Can
I let you modify it, so it may be included in the beta release ? Can you
test it again to see I've not broken the lib code ... ? If you don't have
time, no worry, we'll get it for the final release...

Let us know if you need any help.

Cheers,
Seb

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to