On 15 Nov 2008, at 10:04 , [EMAIL PROTECTED] wrote: > > [jallib] sebastien.lelong commented on revision r550. > Details are at http://code.google.com/p/jallib/source/detail?r=550 > > Score: Neutral > > General Comment: > Who is the author ?
It is my lib. The original ASM is here: http://www.romanblack.com/one_sec.asm I modified the ASM mnemonics like testf and sknz to proper PIC asm. I am not going to bother him: > ;********************************************************************* > ********* > ; ZERO-ERROR ONE SECOND TIMER > ; (Roman Black 2001, public domain, use it as you like) But I would like to have an attribution in the code. Tell me how to do it. > > Line-by-line comments: > > File: /trunk/unvalidated/include/jal/rtc_isr_tmr0.jal (r507) > ====================================================================== > ========= > > Line 2: -- Author: Roman Black, Copyright (c) 2003..2008, all rights > reserved. > ---------------------------------------------------------------------- > --------- > I understand Roman Black is the algorithm's author, not the lib's > author. > You should put yourself as the author's lib, shouldn't you ? If > not, we > should add Roman Black as a jallib author. And ask him first. > > Seb > > Respond to these comments at > http://code.google.com/p/jallib/source/detail?r=550 > -- > You received this message because you starred this review, or because > your project has directed all notifications to a mailing list that you > subscribe to. > You may adjust your review notification preferences at: > http://code.google.com/hosting/settings > > > --- ir EE van Andel [EMAIL PROTECTED] http://www.fiwihex.nl Fiwihex B.V. Wierdensestraat 74, NL7604BK Almelo, Netherlands tel+31-546-491106 fax+31-546-491107 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
