Hi Seb,
Sebastien Lelong wrote:
> I've seen your last commit, and now understand your problem here :) I think
> it's ok having lots of samples, even if very similar, if it's for different
> PICs. But I have doubts when for the same PIC. For instance,
>
> - 18f6310_lcd_hd44780_4_4.jal
> - and 18f6310_lcd_hd44780_4_1.jal,
>
> which differ (IIUC) from how to specify data pins.
Indeed the lcd samples for a specific PIC differ only in the way the
data interface is used: 8 or 4 wires and full register, nibble(s) or
individual bits data paths. And since I have only a single test board
(per number of PIC pins) a single sample would be sufficient. But
multiple samples might have an educational effect.
Because there are many PICs with the same number pins which fit on the
same test-board and the pin layouts/functions of these PICs are
generally the same, the sample programs become almost identical.
There are however some exceptions, for example the 18F1230 has a
different pin layout than the 16f648a. For this case it seems useful to
have samples for both.
I have been thinking about the file naming and decided for appending a
_1, _4 or _8 to indicate the width of the logical data path (1=bit,
4=nibble or 8=full register). This is in style with the library name:
physical interface width 4 or 8 wires. The 'description' of each sample
contains a few lines of explanation.
If you have a better suggestion or other arguments, I'm listening!
Don't forget to fill the CHANGELOG too !)
Will do (I assume Joep will add the lcd_hd44780 refacturing).
Another point: why do we (still) have the 'by_device\<PIC>' directory
structure? Sice all samples have the Picname as prefix we might as well
use 'sample' as lowest level directory: all samples together in a single
directory, just like in the release package. This would also make
browsing the tree at GoogleCode easier.
Regards, Rob.
--
Rob Hamerling, Vianen, NL (http://www.robh.nl/)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---
