Hi Albert, I just read this, didn't not noticed this mail, sorry... About the comment, I'll modify it, obsivously it's wrong ! About percentage calculation, I'll see what I can do.
Thanks for reporting this. Cheers, Seb > Hi Seb, > Also noticed another issue in the comment > > -- This means if duty1 = 0, there's no pwm, if duty1 = 255, you're > closed to > -- (but not at) the maximum pwm > > This is not true, the duty cycly ratio is also dependent on the PR2 > setting, the statement above is only true > if the maximum resolution is use (e.g by using the pwm_max_resolution > call) > > Furthermore, in the procedure pwm1_set_percent_dutycycle(byte in > percent), since the percentage calculation should be > indendent of the pre-scaler setting , I think you can just evalute PR2 > rather than _pr2_4 /_pr2_4 / _pr2_16, this will reduce the amount of > calculations (DWORD multiplications and divisions are expensive) and > code size > > Albert > > > > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
