Hi Albert,

I've committed an new version of adc_channels.jal, as of rev. 1178. Code
deals with exceptions about this 16F72X family. If it occurs there are more
of this kind, we'll have to extract these into a separate file (ala
pinmap.py), easier to maintain.

Can you please give a try, and let me know if it's working so I can close
this issue ?

I've also written unittests, it seems to work in PC-silico, see for instance
test/unittest/16f722_adc.jalt. Test is about setting analog pin, one by one,
and check it's configured as input (thus set_analog_pin() code is correctly
executed).

jallib unittest 16f722_adc

test_test : OK
test_porta_pin_an0_input : OK
test_portb_pin_an0_input : OK
test_porta_pin_an01_input : OK
test_portb_pin_an01_input : OK
test_porta_pin_an012_input : OK
test_portb_pin_an012_input : OK
test_porta_pin_an0123_input : OK
test_portb_pin_an0123_input : OK
test_porta_pin_an01234_input : OK
test_portb_pin_an01234_input : OK
test_porta_pin_an01234-12_input : OK
test_portb_pin_an01234-12_input : OK
test_porta_pin_an01234-12-10_input : OK
test_portb_pin_an01234-12-10_input : OK
test_porta_pin_an01234-12-10-8_input : OK
test_portb_pin_an01234-12-10-8_input : OK
test_porta_pin_an01234-12-10-8-9_input : OK
test_portb_pin_an01234-12-10-8-9_input : OK
test_porta_pin_an01234-12-10-8-9-11_input : OK
test_portb_pin_an01234-12-10-8-9-11_input : OK
test_porta_pin_an01234-12-10-8-9-11-13_input : OK
test_portb_pin_an01234-12-10-8-9-11-13_input : OK
Test results: {'failure': 0, 'notrun': 0, 'success': 23}



Cheers,
Seb
--
Sébastien Lelong
http://www.sirloon.net
http://sirbot.org


2009/8/5 AlbertF <[email protected]>

>
>
> Hi seb,
> I tried the new files from Rob, but got the following error when
> trying to use the ADC Lib
>
> ...projects\jallib_svn\include\peripheral\adc/adc_channels.jal:1708:
> "pin_an5_direction" not defined
> ...\projects\jallib_svn\include\peripheral\adc/adc_channels.jal:1714:
> "pin_an6_direction" not defined
> ...\projects\jallib_svn\include\peripheral\adc/adc_channels.jal:1720:
> "pin_an7_direction" not defined
>
> The device files are looking OK, there is a gap in the numbering of
> AN,looks
> like the ADC lib can not handle this situation, any idea how to
> resolve this issue?
> Albert
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to