Hi Seb, Currently I'm not confident enough to make the changes in the ADC lib, so I leave it to you, I can help you making the unittest though. I also notice another issue with the ADC delay, I think it is a factor 10 too high
-- since we'll use delay_10us, need to divide and adjust -- adc_conversion_delay = adc_conversion_delay / 10 and in adc_ delay_10us(adc_conversion_delay) -- wait acquisition time shouldn't this be _usec_delay( adc_conversion_delay)? Regards Albert ----- Original Message ----- From: <[email protected]> To: <[email protected]> Sent: Friday, October 16, 2009 10:10 PM Subject: [jallib] Issue 99 in jallib: set_analog_pin does not generate code > > > Comment #1 on issue 99 by sebastien.lelong: set_analog_pin does not > generate code > http://code.google.com/p/jallib/issues/detail?id=99 > > 18F4450 has no setup in ADC libraries. Particularly, there's no entry in > /tools/adc/adc_pcfg.py for its datasheet (39760D). It seems famous 18F4550 > has the > same problem (39632D). > > In addition to this, there's no error during compilation. I think I can > adjust this, > and produce an error. > > Ideally, a unittest for these two PICs should written to ensure no such > problems will > occur in the future. > > How do you want to proceed ? I can take care of this, maybe not this WE, > but probably > during next week. > > -- > You received this message because you are listed in the owner > or CC fields of this issue, or because you starred this issue. > You may adjust your issue notification preferences at: > http://code.google.com/hosting/settings > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
