Hi Seb, Sebastien Lelong wrote:
> JSG catches bullet 2 only. And not in documentation. Because it's DITA, > and because DITA has dedicated typed element containing code, ... Sorry, I wasn't clear in this. I was referring to the samples in Jallib. I did a validate run on 16f877_pata_hard_disk.jal and 18f452_pata_hard_disk.jal. No errors were reported! Regards, Rob. > > > 2009/11/30 Rob Hamerling <[email protected] > <mailto:[email protected]>> > > > Hi Matt, > > My compliments, your hard disk tutorial is a nice piece of work! > > But may I suggest some improvements, all having to do with JSG (reason > to use the Jallib group and not Jallist). Some apply to the library, > some to the samples. > > 1. You use the construction: > 'var volatile ... is ...' > This construction is predicated and should be: > 'alias ... is ...' > > 2. No spaces between name of procedure/function and opening parenthesis. > > 3. The indent amount is 3 > > I thought Jallib validate would catch these style violations, but it > seems not. > > Regards, Rob. > > -- > Rob Hamerling, Vianen, NL (http://www.robh.nl/) > > -- > > You received this message because you are subscribed to the Google > Groups "jallib" group. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > To unsubscribe from this group, send email to > [email protected] > <mailto:jallib%[email protected]>. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > > > > > -- > Sébastien Lelong > http://www.sirloon.net > http://sirbot.org > > -- > > You received this message because you are subscribed to the Google > Groups "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. -- Rob Hamerling, Vianen, NL (http://www.robh.nl/) -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
