sebastien.lelong commented on revision r1517 in project jallib. Details are at http://code.google.com/p/jallib/source/detail?r=1517
Score: Neutral General Comment: Hi Matt, I've seen few JSG non-compliant things in your doc, mainly about spaces before () in calls, and _USEC_DELAY that should be lowercase Cheers, Seb Line-by-line comments: File: /trunk/doc/dita/tutorials/tutorial_pata_hard_disk.xml (r1517) =============================================================================== Line 328: send_word (13, 10)</codeblock> ------------------------------------------------------------------------------- no space between send_word and () Line 335: _USEC_DELAY (5_000_000) -- 5 sec delay ------------------------------------------------------------------------------- no space before () _usec_delay should be lowercased (not a constant). check other calls Respond to these comments at http://code.google.com/p/jallib/source/detail?r=1517 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
