sebastien.lelong commented on revision r2194 in project jallib.
Details are at http://code.google.com/p/jallib/source/detail?r=2194
Score: Positive
General Comment:
Hi Matt,
I've had a look at your code, here are some suggestions and questions I
have.
Cheers,
Seb
Line-by-line comments:
File: /trunk/project/slip_networking/18f4620_ping.jal (r2194)
===============================================================================
Line 17: include 18f4550 -- target PICmicro
-------------------------------------------------------------------------------
then file should be renamed to 18f4550_ping.jal ?
Line 82: end loop
-------------------------------------------------------------------------------
why sending fifty "0" ?
Line 140: var byte icmp_message[8] = {0b00001000, 0, 0b11110111,
0b11111110, 0, 1, 0, 0}
-------------------------------------------------------------------------------
could you give more information about this icmp_message ? Is this "Echo or
Echo reply Message" in http://www.faqs.org/rfcs/rfc792.html, page 13 ?
Line 151: network_send_data(icmp_message[count1]) -- send slip packet
data via serial port
-------------------------------------------------------------------------------
you can say:
for 8 using count1 loop
...
end loop
See: http://casadeyork.com/jalv2/jalv2/x552.html
Line 160: _usec_delay(1_000_000)
-------------------------------------------------------------------------------
Is this is avoid DOS attack ? :))
Respond to these comments at
http://code.google.com/p/jallib/source/detail?r=2194
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en.
