Hi Seb,

Triggered by the issue Andre Schaap raised (per msg in Jallist) I've been looking in the device files. All these newer PICs of the 12/16F18/19xx group, but also e.g. 16f720/1, have their ADCS bits in ADCON1 enumerated. This will be fixed with the next version of the device files and declared as bit*3 variable in stead.

I've also looked in the ADC library, in particular in adc_clock.jal and found that it has a somewhat complicated construction for situations where the ADCS bits are split of ADCON0 and ADCON1. This applies to only a few PICs (I think the list below is complete), and this library might be simplified when the device file would contain a pseudo-variable which masks the split for the library so that all PICs can be handled similarly. In fact we did the same to mask the split of ADCON0_CHS bits for the 16f7x7 family. But I'm not 100% sure if this would make adc_clock.jal really better (simpler, better maintainable). Could you check please?

Regards, Rob.



PICs with ADCS bits split over ADCON0 and ADCON1:

16F737
16F747
16F767
16F777
16F818
16F819
16F873A
16F874A
16F876A
16F877A
16F88
18F242
18F2439
18F248
18F252
18F2539
18F258
18F442
18F4439
18F448
18F452
18F4539
18F458



--
R. Hamerling, Netherlands --- http://www.robh.nl

--
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en.

Reply via email to