On Sun, Nov 28, 2010 at 2:11 AM, Joep Suijs <[email protected]> wrote:
> Hi Rob, > > Vasile is the right person to answer. > In revision 1912, Vasile added quite a lot: - documentation (which Richard removed, since this is better described > in the specific libraries like lcd_hd44780_4 > - some functions (including the one you mention) > - removed inline pragma's > - and added his name to the adapted-by list > > In revsion 1913, much of this was reverted (including his name) but > not all (mainly, inline pragma's and the function mentions and > duplicated documentation) > I remember I've tried to add a procedure for movie defined graphic chars and that add a lot of errors in all samples using LCD, so as I recall, I gave up and revert to the original version. Sorry if I create problems, I decided is much easy to modify and create my own libraries than maintain compatibility on all jallib examples. Vasile > > > > 2010/11/28 vasile surducan <[email protected]>: > > > > > > On Sun, Nov 28, 2010 at 12:48 AM, <[email protected]> wrote: > >> > >> Comment #3 on issue 137 by robhamerling: Error in LCD libraries > >> http://code.google.com/p/jallib/issues/detail?id=137 > >> > >> The file lcd_hd44780_common.jal contains a procedure _hd447800_init with > >> the following accompanying text: > >> > >> This procedure is called from lcd_init of the interface used. lcd_init > >> brings > >> up the interface and powers up the display. > >> > >> But I cannot find any other library calling this procedure. > >> It seems the creator of this library forgot something..... > >> Richard and Joep are mentioned in the header. Could one of you comment? > >> > > The _hd44780_init() procedure is wrong defined as "not realy > internal, > > but not for users", > > the LCD will work without it with LCD implicit settings (which you don't > > know unless read the LCD datasheet), however using such an initialization > > procedure for a specific LCD (2 or 4 lines, etc) is a good option. So the > > procedure can be called by the user itself. > > Vasile > > > > -- > > You received this message because you are subscribed to the Google Groups > > "jallib" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]<jallib%[email protected]> > . > > For more options, visit this group at > > http://groups.google.com/group/jallib?hl=en. > > > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
