And the same is assumed with glcd_ks0108.jal lib, as it uses 5x7 font by default (lcd_write_char works with hard-coded values)
Seb 2011/2/19 <[email protected]> > Comment by sebastien.lelong: > > Score: Neutral > > General Comment: > About using fonts, how to stay generic > > Line-by-line comments: > > File: /trunk/include/external/lcd/glcd_stm032qvt-003.jal (r2472) > > =============================================================================== > > Line 344: -- must set: glcd_text_height, glcd_text_width and > > ------------------------------------------------------------------------------- > Comment says glcd_text_height and glcd_text_width must be set. But > implementation doesn't use them. I understand glcd_text_height = 12 and > glcd_text_width = 8 in this procedure. I think this is because you're using > glcd_8x12_font in your sample. But as a consequence, your code isn't > generic. > > I think glcd_text_height and glcd_text_width are closed to what Richard > used in his Nokia 3310 with var_nmb variable, storing the number of bytes > required to store a char. > > Do I understand well ? If so, font libs must declare this. > > For more information: > http://code.google.com/p/jallib/source/detail?r=2472 > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
