Greetings Seb, Sponsored-by may be used to show when work is done for hire, versus hobby/fun.
You missed spi_master_common.jal ? I didn't create / author this file -- presumably it is the result of your refactoring, so it seems to me you should be its author. If you wish, you can mention that you cut/ pasted it from an existing file. Thank you, William On May 4, 2:48 am, Sebastien Lelong <[email protected]> wrote: > Should I remove "Sponsored by" field ? I didn't know about this one... > > Seb > > 2011/5/4 Sebastien Lelong <[email protected]> > > > > > > > > > > > 2011/5/4 William <[email protected]> > > >> Seb, > > >> That is surprising, since you added an inline statement to your > >> version of spi_init. > > > Yes, to make it equivalent as before. > > >> Please add your name to the files as requested. > > > Adapted-by. I don't own the authorship of spi_master_hw2.jal. My > > contribution was to "sed" register names... > > > Cheers, > > Seb > > >> On May 4, 2:08 am, Sebastien Lelong <[email protected]> > >> wrote: > >> > Hi William, > > >> > Le 4 mai 2011 à 09:02, William <[email protected]> a écrit : > > >> > > I hope you re-tested all of the existing samples that were using the > >> > > library also, on real hardware? :-) > > >> > IIRC I compared generated HEX file's md5sum before and after > >> > refactoring. They were the same. > > >> > Cheers > >> > Seb > > >> > > On Apr 19, 5:07 am, [email protected] wrote: > >> > >> Revision: 2583 > >> > >> Author: sebastien.lelong > >> > >> Date: Tue Apr 19 03:06:45 2011 > >> > >> Log: added SPI Master lib running MSSP2 module, refactored > >> > >> common > >> > >> constants to spi_master_common.jalhttp://code.google.com/p/jallib/ > >> > >> source/detail?r=2583 > > >> > >> Added: > >> > >> /trunk/include/peripheral/spi/spi_master_common.jal > >> > >> /trunk/include/peripheral/spi/spi_master_hw2.jal > >> > >> Modified: > >> > >> /trunk/include/peripheral/spi/spi_master_hw.jal > > >> > > -- > >> > > You received this message because you are subscribed to the Google > >> > > Groups "jallib" group. > >> > > To post to this group, send email to [email protected]. > >> > > To unsubscribe from this group, send email to > >> [email protected] > >> > > . > >> > > For more options, visit this group athttp:// > >> groups.google.com/group/jallib?hl=en > >> > > . > > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "jallib" group. > >> To post to this group, send email to [email protected]. > >> To unsubscribe from this group, send email to > >> [email protected]. > >> For more options, visit this group at > >>http://groups.google.com/group/jallib?hl=en. > > > -- > > Sébastien Lelong > >http://www.sirloon.net > >http://sirbot.org > > -- > Sébastien Lelonghttp://www.sirloon.nethttp://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
