Hi Seb,

On May 6, 11:43 am, Sebastien Lelong <[email protected]>
wrote:
>
> in order to avoid duplication of code,
> we refactored the setting mode code into an other procedure, while calling
> it within new init procedure.
>

So far as I can determine, this is the very first time you actually
explained why you rewrote spi_init() -- 'to avoid duplication of
code'.  But does it really?  I may look more pleasing (to you) in the
source file, but had you left it as the original, I would be much
happier.   And I wonder how much, if any, your version saves actual
code space in flash?  Remember you must include the overhead of
calling/returning the new function, unless you decide to inline it.

William

-- 
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en.

Reply via email to