On 28-11-12 10:52, [email protected] wrote:

Log: Final commit on this, honest!

http://code.google.com/p/jallib/source/detail?r=3136

Modified:
/trunk/include/jal/reboot.jal

Never say 'final'!
I've some comments:
1. Why do you use a loop with _usec_delay()?
   Why not use _usec_delay(2_000_000)
2. 'pragma error' is superseded by '_error'
   See the compiler docs.
3. The use of 'target_cpu < PIC_16' is dangerous.
   These constants are only to be used
   for '==' and '!=' expressions.  Better use:
   if (target_cpu == PIC12 | target_cpu == PIC14)

Regards, Rob.

--
R. Hamerling, Netherlands --- http://www.robh.nl

--
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en.

Reply via email to