Hi Urmas,
On 24.10.14 11:38, [email protected] wrote:
Revision: 3599
Author: urmas.joeleht
Date: Fri Oct 24 09:38:42 2014 UTC
Log: Bosch BMP085 pressure sensor
https://code.google.com/p/jallib/source/detail?r=3599
Added:
/trunk/include/external/pressure/bmp085.jal
On behalf of all Jallib users thank you for your contribution!
Apart from Matt's suggestion to use the validation process (on sample
and library), I have some suggestions for improvements not catched by
jallib validation.
The names of all *global* variables (and constants) should have a prefix
with the name of the libary, in your case 'bmp085_'.
For example:
var word ac4, ac5, ac6
should really be
var word bmp085_ac4, bmp085_ac5, bmp085_ac6
This is required to avoid duplicate names when several libraries and the
user program would use ac4, ac5, etc. as global variables.
I think you forgot: 'svn propset svn:keywords Revision'
which automatically adds the revision number in your library.
For our automatic documentation generation system the 'Description'
field should be one block of text. The first empty line (with or without
'--') is considered the end of the description. So you shold
insert lines with "-- ." when you want a space line in the text.
This applies also to other header sections.
I was surprised to see my name as author in your sample, please use your
own name and correct copyright years, compiler version, PIC type in the
description.
Hopefully you understand why this extra work is required by Jallib.
Regards, Rob.
--
R. Hamerling, Netherlands --- http://www.robh.nl
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/jallib.
For more options, visit https://groups.google.com/d/optout.
