Hi all, Correction. Apparently some more functions are used from the adc_channel library so deleting it will make more samples to fail. I could modify the library to only remove the JANSEL part but still the library remains incomplete.
So I have 2 options: 1) Modify an incomplete library and keep it incomplete. Deleting the samples that fail on JANSEL. 2) Delete it including all samples that fail. Thiese are more samples about 25 adc sample files. Kind regards, Rob On Friday, April 12, 2019 at 9:07:49 PM UTC+2, Rob Jansen wrote: > > Hello all, > > I am updating some Python scripts for device file generation to lower the > maintenance of them. Next to that I want to clean up stuff that is > incomplete. > > The biggest change is the removal of the datasheet and programming > specification because these numbers seem to change once and a while. This > does not lead to any problems when recompiling all samples. > > Another point of concern it the generation of JANSEL. The adc_channel > library is far from up to date and the creation of JANSEL is also a high > maintenance task in the Python script for device file generation. When > removing the JANSEL aliases from the device file some sample files no > longer work because adc_channel. jal is missing the JANSEl aliases. > > But still because the adc_channel.jal is far from complete (and not easy > to expand or high maintenance to keep it up to date for all available PICs) > I still propose to remove JANSEL and remove this library. This also means > that I need to delete the following sample files. > > 12f683_pwm_adc > 16f88_adc_highres > 16f88_adc_independent > 16f88_adc_lowres > 16f723_adc_independent > 16f886_pwm_adc_freq > 16f886_pwm_adc_res > 16f1827_adc > 18f14k50_adc_independent > > I know that deleting stuff is not the way to go but neither is maintaining > libraries that are not complete or not usable for other PICs. > > Let me know what you think. > > Thanks. > > Kind regards, > > Rob > > -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/jallib. For more options, visit https://groups.google.com/d/optout.
