Hi Rob and all, I made some changes to the blink-a-led script and it needs some fine tuning but with this change the number of blink samples goes from around 1000 to more than 1500. I think if we add this people will no longer see the forest through the trees. I agree with you that we would need some kind of split. I think the blink samples should be separate from the library samples.
I would not split it into HS, INTOSC and USB (there are only around 128 USB samples) but would rather split it in 10, 12, 16, 18 (although there are not many 10 and 12 samples). In Jallib 1.6.0 there are around 2.000 sample files of which around 1.000 are currently blink sample files. To summarize I would propose: -) A library_sample directory (1000 files) -) A blink_sample directory (1500 files with the modified script) --) Under the blink_sample the following directories: ---) 10, 12, 16, 18 The motivation is that if you look for a library sample file, you use the name of the library so there should be no spilt under the library sample directory. If you look for a blink sample file you use the PIC type so a split seems logical. With the modified script, the following number of blink sample files are created: -) 10 : 6 -) 12: 27 -) 16: 522 (f and lf versions) -) 18: 933 (f and lf versions) I know this is easier said than done since it requires at least the following: -) A restructuring on GitHub (the easiest part) -) An update of TORELEASE (easy but a lot of work) -) Most important a change of the makefiles for the build and release (the unknown part for me) on the server of Kyle & Matt? I know this discussion has been done in the past but I wonder if we are at a crosspoint to decide if we keep it like this or make a change. I am not sure if there are also other ideas for changes that should then be incorporated. @All. Share your thoughts and concerns. Thanks Kind regards, Rob ________________________________ Van: [email protected] <[email protected]> namens Rob Hamerling <[email protected]> Verzonden: zaterdag 13 februari 2021 13:59 Aan: [email protected] <[email protected]> Onderwerp: Re: [jallib] Question on blink samples Hi Rob, On 13/02/2021 12.29, [email protected]<mailto:[email protected]> wrote: The blink-a-led-py script generates this samples but will initially generate a crystal version since that is what it checks as first item and then it stops. It can also generate the version with the internal oscillator but that is not done when a HS version is created. I didn't check the current blink-a-led script, but as far as I remember after initially generating an HS version for a certain PIC, the script checks if this PIC is member of a list of PICs for which ALSO a blink sample with INTOSC and/or a sample for USB must be generated. So all variants would be generated in one run. If I change the order to first check for the internal oscillator, a lot of new blink samples using the internal oscillator are created. It will then not create the HS version (crystal version). My questions are: 1) Should we move the priority from HS before internal oscillator to internal oscillator before HS? 2) Do we still want to keep the HS version if an internal oscillator version is available or should we remove them? Currently the script generates one of the two but I could change it to create both. I would like to suggest to have all possible types of blink-a-led samples for all PICs and improve the directory structure: a subdirectory for HS, INTOSC and USB variants of the blink samples and a separate directory for the other samples (thus 4 sample directories). Regards, Rob. -- Rob Hamerling, Vianen, NL -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/ca2f7c50-cac1-769b-4553-63f22e79028c%40gmail.com<https://groups.google.com/d/msgid/jallib/ca2f7c50-cac1-769b-4553-63f22e79028c%40gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/AM0PR07MB6241E99E4BBFC68B7BB42FC6E6899%40AM0PR07MB6241.eurprd07.prod.outlook.com.
