I am ok with the change. Do as Rob suggested with aliases and warnings in the old library.
What libraries will change? Matt. On Sunday, October 16, 2022 at 4:45:17 AM UTC-4 [email protected] wrote: > Hi Oliver (Kiste ๐), > > We could indeed add an alias to the library like *alias spi_host_hw is > spi_master_hw *and use spi_host_hw in all new sample files (and use that > in all current sample files and libraries) so that people get used to it. > > In my ili9341 library I am using SPI (but am moving the initialization > part of the spi interface to the sample file so still some changes are made > to this library) and will use *ili9341_spi_host* in my library so the > sample program has to define this alias. > > Another thing we can do is mention that the library is no longer > maintained (give a compiler warning when using it), make a copy of it to > spi_host_hw and if there are any improvements needed, they will only be > done in this new version. I know there have been changes in newer PICs that > require an update of the SPI library but I did not yet find the courage to > work on that. > > BTW. In all the years that I am using JAL (since 2013) I have encountered > only once that one of my projects did not compile with a newer version of > Jallib which was a simple fix. I think there was a change in a device file > (but am not sure). The older Jallib versions can still be downloaded from > the download site. > > Kind regards, > > Rob > > ------------------------------ > *Van:* [email protected] <[email protected]> namens ZetWeeh < > [email protected]> > *Verzonden:* zondag 16 oktober 2022 10:19 > *Aan:* [email protected] <[email protected]> > *Onderwerp:* RE: [jallib] exit of master/slave? > > > Hi > > I suggested the same with aliases in a private mail to Rob. > > Make an announcement on the website that within 2 (?) years the old libs > cannot be used anymore. > > And maybe itโs possible to make a message in the compiler like: > deprecated; use newer library. > > Than you have for some time two libs: the old one with the aliases (for > example spi_master_hw.jal and the new one = spi_host_hw.jal). > > Greetings, > > Peter > > > > *Van: *vsurducan > *Verzonden: *zondag 16 oktober 2022 06:31 > *Aan: *[email protected] > *Onderwerp: *Re: [jallib] exit of master/slave? > > > > What if you put these in the library header: > > -- alias master = host in Microchip datasheet, please be aware > > -- alias slave = client in Microchip datasheet, please be aware > > > > A good practice would be that at the end of any project, ALL libraries, > the used compiler, schematic, PCB, machine files ( gerber excelon), all > components datasheet used in the project, source code (well commented) and > the hex file to be saved in two different places. > > > > > > On Sun, Oct 16, 2022 at 4:27 AM Matthew Schinkel <[email protected]> > wrote: > > Hi, how many files are affected? > > > > Is someone offended by this? If someone is offended we can change it, else > it seems like quite a lot will need to be changed and won't be backwards > compatible. > > > > Matt. > > On Saturday, October 15, 2022 at 10:34:00 AM UTC-4 [email protected] > wrote: > > Hi Vasile, > > > > We can keep the older version on GitHub. Not all files on GitHub are part > of a release, that is determined by the file TORELASE on GitHub. > > > > On GitHub you also find a directory called 'Casualties' where some older > stuff is stored but you could also just remove it from the release (after > some time). > > > > Kind regards, > > > > Rob > > > > *Van:* [email protected] <[email protected]> namens vasi vasi > <[email protected]> > *Verzonden:* zaterdag 15 oktober 2022 14:35 > *Aan:* [email protected] <[email protected]> > *Onderwerp:* Re: [jallib] exit of master/slave? > > > > This will not be a workable solution if you do not keep the old libraries > at least in repository, even if you do not release them anymore. You don't > know how many valuable projects are out there, is a real pain for new > development teams to deal with old, deprecated firmware, written in an > alien language that does not have support anymore... if you understand what > I mean... > > > > On Sat, Oct 15, 2022 at 12:31 PM Rob CJ <[email protected]> wrote: > > Hi Rob, > > > > I agree that we should keep it in line with Microchip to keep consistency. > > > > What we could do is the following: > > - Copy the current libraries using the new terminology, so for example > *spi_master_hw* to *spi_host_hw* > - Keep the current libraries for now but add something like *_warn > "This library will be deprecated, use spi_host_hw*. In this way the > library can still be used and it gives the JAL users time to switch to the > new library convention. We could keep the old libraries for one release > and > remove them from the next release. > - Modify all current sample files so they use the new libraries. > > Would this be a workable approach? > > > > Kind regards, > > > > Rob > > > > *Van:* [email protected] <[email protected]> namens Rob > Hamerling <[email protected]> > *Verzonden:* woensdag 12 oktober 2022 19:36 > *Aan:* jallib <[email protected]> > *Onderwerp:* [jallib] exit of master/slave? > > > > > Hi guys, > > Like similar changes in other places, I see in the Microchip datasheets > that the terms 'master' and 'slave' are being replaced by 'host' and > 'client'. Seems a positive and desirable change to me. I would like to > suggest to follow Microchip in this for Jallib. I'm afraid this is not a > simple operation. It is not only about file names, but also related > 'includes' in samples. But it will also have effects on existing user > programs! What are your thoughts about this? > > Regards, Rob > > -- > *Rob H*amerling, Vianen, NL > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/a87bb739-c320-a351-698e-3d5264087327%40gmail.com > > <https://groups.google.com/d/msgid/jallib/a87bb739-c320-a351-698e-3d5264087327%40gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/GVXP195MB16376C1A737B25302F0787A5E6279%40GVXP195MB1637.EURP195.PROD.OUTLOOK.COM > > <https://groups.google.com/d/msgid/jallib/GVXP195MB16376C1A737B25302F0787A5E6279%40GVXP195MB1637.EURP195.PROD.OUTLOOK.COM?utm_medium=email&utm_source=footer> > . > > > > -- > > Vasi > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/CABsDq%3D-k7Zxa%3D0YqALyetLkrPnjKY0P_PZMypzS%3DTDA1ik0Mdg%40mail.gmail.com > > <https://groups.google.com/d/msgid/jallib/CABsDq%3D-k7Zxa%3D0YqALyetLkrPnjKY0P_PZMypzS%3DTDA1ik0Mdg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/68061027-3571-475b-8ddf-bb217473c763n%40googlegroups.com > > <https://groups.google.com/d/msgid/jallib/68061027-3571-475b-8ddf-bb217473c763n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/CAM%2Bj4qtJ6Kt1%3DM2sj9XO6wLMZJf14QE86WwGg0FtoXHetswyRw%40mail.gmail.com > > <https://groups.google.com/d/msgid/jallib/CAM%2Bj4qtJ6Kt1%3DM2sj9XO6wLMZJf14QE86WwGg0FtoXHetswyRw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jallib/40464FA0-4AA2-48B5-AE26-E41B517FB0EA%40hxcore.ol > > <https://groups.google.com/d/msgid/jallib/40464FA0-4AA2-48B5-AE26-E41B517FB0EA%40hxcore.ol?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/e45dd005-74d9-4b4f-b7d1-cfc2e92235d8n%40googlegroups.com.
