Hi all,
I almost have the i18n review also finish but I've found several issues
that I'll leave unfix because I think they need further changes in the code.
We should avoid, as much as possible, comparisions (or other logic)
relaying directly in strings shown at user interface. For example:
wsList.setModel(new WsUrlTableModel(tdat));
wsList.getColumn("Status").setMinWidth(10);
[...]
public String getColumnName(int column)
{
if (column == 1)
{
return "Status";
}
return "Service URL";
}
If the string gets translated, the application will not work properly (or
even won't work at all).
I can fix these type of issues but, from my point of view, it's better to
them in the main branch instead of the i18n branch, because they will need
not-i18n-changes before to fix i18n. What do you think about that?
Cheers,
David
_______________________________________________
Jalview-dev mailing list
[email protected]
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev
