There are a few calls to this scattered around the codebase, mostly after OutOfMemoryError, but also in
AlignFrame.copy_actionPerformed() Desktop.internalFrameClosed() Desktop.closeAll_actionPerformed() OverviewCanvas.draw() I'm not sure there is ever a good reason to call this routinely. I noticed that if you open a large alignment, then open any panel (say Feature Settings, or PCA Chooser) and then close it, there is a very noticeable pause, and jvisualvm shows a big spike in CPU and GC. It seems to behave like a blocking call to gc() rather than the usual background thread behaviour. Commenting out the call in Desktop.internalFrameClosed() removes the delay. Should we get rid of it? Mungo [University of Dundee shield logo]<http://uod.ac.uk/sig-home> Mungo Carstairs Jalview Computational Scientist The Barton Group Division of Computational Biology School of Life Sciences University of Dundee, Dundee, Scotland, UK www.jalview.org<http://www.jalview.org> www.compbio.dundee.ac.uk<http://www.compbio.dundee.ac.uk> [email protected]<mailto:[email protected]> [University of Dundee Facebook]<http://uod.ac.uk/sig-fb> [University of Dundee Twitter] <http://uod.ac.uk/sig-tw> [University of Dundee LinkedIn] <http://uod.ac.uk/sig-li> [University of Dundee YouTube] <http://uod.ac.uk/sig-yt> [University of Dundee Instagram] <http://uod.ac.uk/sig-ig> [University of Dundee Snapchat] <http://uod.ac.uk/sig-sc> We're Scottish University of the Year again!<http://uod.ac.uk/sig-strapline> The Times / Sunday Times Good University Guide 2016 and 2017 The University of Dundee is a registered Scottish Charity, No: SC015096
_______________________________________________ Jalview-dev mailing list [email protected] http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev
