hbedi       01/11/30 01:12:31

  Modified:    src/java/org/apache/james/nntpserver NNTPHandler.java
  Log:
  NewGroups did not work with KNode.
  Bad response code and INN incompatibility
  
  Revision  Changes    Path
  1.9       +15 -3     
jakarta-james/src/java/org/apache/james/nntpserver/NNTPHandler.java
  
  Index: NNTPHandler.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-james/src/java/org/apache/james/nntpserver/NNTPHandler.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- NNTPHandler.java  2001/11/28 07:08:56     1.8
  +++ NNTPHandler.java  2001/11/30 09:12:31     1.9
  @@ -244,10 +244,22 @@
       }
       private void doNEWGROUPS(StringTokenizer tok) {
           // see section 11.3
  -        writer.println("230 list of new newsgroups follows");
  +        // there seeem to be few differences.
  +        // draft-ietf-nntpext-base-13.txt mentions 231 in section 11.3.1, 
  +        // but examples have response code 230. rfc977 has 231 response code.
  +        // both draft-ietf-nntpext-base-13.txt and rfc977 have only group names 
  +        // in response lines, but INN sends 
  +        // '<group name> <last article> <first article> <posting allowed>'
  +        // NOTE: following INN over either document.
  +        writer.println("231 list of new newsgroups follows");
           Iterator iter = repo.getGroupsSince(getDateFrom(tok));
  -        while ( iter.hasNext() )
  -            writer.println(((NNTPGroup)iter.next()).getName());
  +        while ( iter.hasNext() ) {
  +            NNTPGroup group = (NNTPGroup)iter.next();
  +            writer.println(group.getName()+" "+
  +                           group.getLastArticleNumber()+" "+
  +                           group.getFirstArticleNumber()+" " +
  +                           (group.isPostAllowed()?"y":"n"));
  +        }
           writer.println(".");
       }
       // returns the date from @param input.
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to