I just looked at that again, and it doesn't look for the space between : and < what happens is that it splits at the first space, and the command is the first part, then it splits at the : and the sub command is the first part, but the second part is not split further, it is passed as the argument, in the case of MAIL FROM this is assumed by doMAIL() to be the sender and nothing else, which I assume stuffs it because it doesn't end with >, or can't be parsed into a mail address.
What I need to know before I can sort it out is whether there is a list of these additional arguments and which commands they can be applied to, Serge has identified SIZE, I found AUTH while I was patching this last time, are there any more? We need to add another layer of command parsing to deal with them. d. > -----Original Message----- > From: Danny Angus [mailto:[EMAIL PROTECTED]] > Sent: Thursday, December 06, 2001 9:58 AM > To: James Developers List > Subject: RE: MAIL FROM and spaces > > > I'll have another go at parseCommand() in SMTPHandler > > > -----Original Message----- > > From: Serge Knystautas [mailto:[EMAIL PROTECTED]] > > Sent: Wednesday, December 05, 2001 11:50 PM > > To: [EMAIL PROTECTED] > > Subject: MAIL FROM and spaces > > > > > > Ok, after saying that all those messages didn't put a space between MAIL > > FROM: and the <>, I'm seeing in EHLO mode the commands are a bit > > different. > > I recently turned on the SIZE limit in SMTP, which means JAMES > > acknowledges > > with an EHLO and a 250-SIZE line. Remote servers are noticing this, so > > they're sending the complementary SIZE parameter in the MAIL FROM. This > > means they send the following: > > > > MAIL FROM:<username@domain> SIZE=2148 > > > > Where 2148 is the number of bytes of the message. Note there is now no > > space between "...FROM:" and "<username...". Incidentally, this size is > > sent so as while it gives a series of RCPT TO commands, our > server can see > > if any of those users have a quota that this message would > > exceed, and then > > reject receiving the message for that user, using a 452 reply code. > > > > Anyway, James is failing on this MAIL FROM format, so the size > limitation > > code isn't 100% just yet. I'm not sure quite how many emails we're > > rejecting at this point, but I'm either going to patch this or > > turn off the > > size limit setting on my server soon. > > > > Serge Knystautas > > Loki Technologies - Unstoppable Websites > > http://www.lokitech.com/ > > > > > > -- > > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
