Got all my intended changes done... I have to commit my changes to changelog.xml, but otherwise everything is in CVS and seems to be running well.
On the 0-byte problem, I was able to avoid the patch that renamed the message when storing it back to the mail repository (on the temporary failures in remote delivery is where it was having problems). What I did was make the file repository code smarter so it could see that it was saving to the same place it was reading. Then if the message was not modified, it would not save the stream (it still saves meta-delivery info as that always worked and needs to get saved). If the message is modified, it will go ahead and save it, but that should be fine because for the message to be modified, it had to have been loaded into memory. This allows us to call store(Mail) worry free (at least that's the goal) rather than coding around repository implementation problems. Anyway, there are also much better error messages in remote delivery, it's much better about calling a temporary delivery error a temporary one. Also, I removed an isClosed() check in my DB pooler-hack that was causing a HUGE performance hit... the pooler already assumes that messages in the pool are valid, so this extra check didn't seem worth the costs. Eventually I'm still looking to move towards DBCP once they make a release. Maybe we might even dare call this new release a beta?.. I think the current functionality is getting rather stable... it'd be nice to move to the official releases of Avalon, or maybe go alpha with this release, and then once the Phoenix part is final we can update to that and release accordingly. -- Serge Knystautas Loki Technologies - Unstoppable Websites http://www.lokitech.com/ Serge Knystautas wrote: > There have been a few fixes since alpha 2, the ones I remember off the > top of my head include: > - fixed delay in db repository > - fixed pop3 dot-stuffing bug > - fixed bounce method to use Return-Path header if there > probably a few other fixes... hopefully people have been updating the > changelog.xml file (hint hint). > > I'm almost ready to deploy a patch to better identify temporary delivery > exceptions and clean up the messages a bit (like instead of saying, > "javax.mail.SendFailedException 512 3 I don't likeyou", have the error > message say, "When I tried to deliver to the mail server at > stupid.mailserver.com, it told me: [newline]512 3 I don't likeyou". > > Also, I'm going to try to patch the file repository so you can save a > message with the same message name. I think that's the better fix for > the delivery problems. If I can't do that easily, I'll apply that patch > that renames the messages when it has to store messages for replies > (which is currently creating the 0-byte problem in the file repository). > > So, how about a vote for alpha 3 pending these 2 fixes? -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
