NNTPHandler.java does not dispatch the next command to the method doNEXT.
Additionally the commands next and last behave like
 
send(header(CurrentArticleNumber++));
 
while they should behave like:
 
send(header(++CurrentArticleNumber));
 
The attached patch corrects both problems.
 
Christian
 
Index: NNTPHandler.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-james/src/java/org/apache/james/nntpserver/NNTPHandler.java,v
retrieving revision 1.15
diff -u -r1.15 NNTPHandler.java
--- NNTPHandler.java    18 Aug 2002 07:30:17 -0000      1.15
+++ NNTPHandler.java    26 Aug 2002 19:13:57 -0000
@@ -220,6 +220,8 @@
             doLISTOVERVIEWFMT();
         else if ( command.equals("GROUP") )
             doGROUP(tokens.hasMoreTokens()?tokens.nextToken():null);
+        else if ( command.equals("NEXT") )
+            doNEXT();
         else if ( command.equals("LAST") )
             doLAST();
         else if ( command.equals("ARTICLE") )
@@ -513,8 +515,8 @@
         else if ( group.getCurrentArticleNumber() >= group.getLastArticleNumber() )
             writer.println("421 no next article in this group");
         else {
-            NNTPArticle article = group.getCurrentArticle();
             group.setCurrentArticleNumber(group.getCurrentArticleNumber()+1);
+            NNTPArticle article = group.getCurrentArticle();
             StringBuffer respBuffer =
                 new StringBuffer(64)
                         .append("223 ")
@@ -534,8 +536,8 @@
         else if ( group.getCurrentArticleNumber() <= group.getFirstArticleNumber() )
             writer.println("422 no previous article in this group");
         else {
-            NNTPArticle article = group.getCurrentArticle();
             group.setCurrentArticleNumber(group.getCurrentArticleNumber()-1);
+            NNTPArticle article = group.getCurrentArticle();
             StringBuffer respBuffer =
                 new StringBuffer(64)
                         .append("223 ")

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to