yes Noel, I agree. > -----Original Message----- > From: Noel J. Bergman [mailto:[EMAIL PROTECTED]] > Sent: 30 September 2002 11:07 > To: James-Dev Mailing List > Subject: Redirect "bug" (static with "sender") > > > Danny, > > In Redirect.init(), you have the following: > > sender = (getSender() == null) ? getMailetContext().getPostmaster() : > getSender(); > > In getSender(), you have: > > if(sr.compareTo("sender") == 0) { > return null; > } > > In service, you have: > > if(sender == null) { > reply.setHeader(RFC2822Headers.FROM, > message.getHeader(RFC2822Headers.FROM, ",")); > sender = new > MailAddress(((InternetAddress)message.getFrom()[0]).getAddress()); > } > > It seems to me that the code is wrong. Even though the settings may be > static, the expected behavior is that the SENDER will be used, rather than > the Postmaster. Essentially, using the keyword "sender" implies that the > eventual sender value is dynamic, regardless of the static setting. The > current behavior is more of a side effect than the behavior a user would > expect. > > Do you agree? > > --- Noel > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
