----- Original Message ----- From: "Peter M. Goldstein" <[EMAIL PROTECTED]> > AuthService is not worth fixing, for all the reasons I laid out > in my previous email. I have very strong feelings on this matter
You were pointing out a problem in the AuthService, I am suggesting remove the AuthService with something that addresses what you laid out in your email (replace with AuthServiceFactory - also suggested by you). We may be talking about the same thing. > have an extensive background in authentication and authorization - and > really feel that the AuthService should be retired. Agreed, why don't you fix the rest, I'll address the AuthSevice if you like. Don't have lot of Auth and Authorization software experience but my professional job is security. (not often bug free though). Please feel free to review it. Regarding comments etc. - How about use @see where possible and - Not do javadocs on private methods/variables. There does not really seem to be a gain in javadoc for implementation details. Does that sound right ? Harmeet -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
