Peter, > > > Harmeet, > > > > Removing patch that was not submitted for review, > > > > 1. It was not a patch > > > > Yes, it was. It was a modification to the existing code base. Ergo, it > was a patch. That's why we use the [PATCH] flag.
There is no need to be nuts over code that is for testing and proposals. PATCH is reference to production code not test code. If you care about bundling ~10k or so test files in production jar file, the right fix is to remove testing package from build file. Please note that would be a change from what has been around for a long time. I don't think it is worth doing, but again if you feel so strongly about it. > > > > introduced inappropriate files into the repository, > > > > 2. Test files are not inappropriate. They should be in the repository, > > maybe > > you mean files not in the right place. > > That's what inappropriate means. I was trying to make sense of your action and attempting to be nice. testing package is where test code has been going from start. I haven't seen you suggest any other location and you seem to have arbitrarily decided what inappropriate is. Your actions are very inappropriate. > > > > > and violated James stated coding standards. > > > 3. What coding standard are you talking about ? > > There is one here: http://jakarta.apache.org/james/code-standards.html > > Can't see anything that collides with this. Do you know of another > coding > > standard ? > > > > This is the very coding standard. Please read point #4. Your methods You want javadocs on test methods ? The point #4 was ment to push develepors in a direction not act as justification for removing files. You are picking things out of context and using it to justify abuse. That too on code that is only for testing. This is very unfortunate. Harmeet -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
