Alan, [Resending. Weird, but it looks like the attachments were stripped.]
Thanks. I did a little bit of cleanup work on it, but I haven't compiled
the changes, yet (birthing pains in HEAD). Still, I thought that you might
want to look over what I did, finish any cleanup (like with the docs), and
do some testing.
--- Noel
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Sunday, February 09, 2003 16:17
To: James Developers List
Subject: CIDr Addition
Just read the Submit Patch post and understand that - have
winCVS and am gettting aquainted with it ...
I am adding two new classes and patching two others heavily.
The attached files are my contribution to James for the CIDR
process we spoke of earlier.
It compiles and runs - I will be testing this more later on
this afternoon, but in the meantime, I thought I would pass
them off for review.
I can diff the RemoteAddressInNetwork and
RemortAddressNotInNetwork and pass those in as patches, but
without the other two classes, they are meaningless.
Thanks for your time ...
Alan
----- Message Forwarded on 2003-02-09 -----
From: "alan.gerhard" <[EMAIL PROTECTED]>
To: "James Users List" <[EMAIL PROTECTED]>
Subject: RE: CIDR Notation
Date: Sun, 02 Feb 2003 03:00:52 -0500
Noel -
You are suggesting to create a
apache.mailet.GenericAddressMatcher abstract that folds most
of the 'common' code of the RemoteAddrInNetwork and
RemoteAddrNotInNetwork classes - similar to the
GenericRecipientMatcher abstract ..
Okay - I'll have a good at it;
see what I can come up with.
> Alan,
>
> I don't believe that you are missing something. It isn't
> an oversight, just nothing that anyone got around to.
> When I first picked up the code, it didn't accept domain
> names, either. I think I have some code for CIDR around
> here somewhere, but never finished adding it to those
> matchers.
>
> Actually, if you're going to do it, I suggest that you
> take those matchers, factor out most of the code into
> GenericAddressMatcher, and then subclass them for the
> specific behavior. That'll make it easier to enhance them
> in the future.
>
> --- Noel
Network.zip
Description: Zip compressed data
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
