Kevin,

Most of the James code was overhauled last summer to push commands to
UPPERCASE, which is more efficient than using equalsIgnoreCase.  Apparently
this was one area where the changes were incomplete.  The change would be to
insert

        command = command.toUpperCase(Locale.US);

before line 560.  I don't notice any other missing places in the NNTP, SMTP
or POP3 handlers.

Thanks for the report.  I've applied the fix to the CVS for the next builds.

        --- Noel

-----Original Message-----
From: Kevin Schmidt [mailto:[EMAIL PROTECTED]]
Sent: Sunday, February 16, 2003 19:21
To: [EMAIL PROTECTED]
Subject: Authenticated NNTP Problem

Hi,

I set up James 2.1.1 to require authenticated NNTP and then attempted to
use it with Mozilla 1.3b and Netscape 4.75.  Both reported "501 Syntax
Error".  With logging turned on I saw that both were sending "AUTHINFO
user <username>" and in looking at the code in NNTPHandler.java, I saw
that James was expecting an uppercase "USER".

Changing the command checking to use
"command.equalsIgnoreCase(AUTHINFO_PARAM_USER)" (line 560) and
"command.equalsIgnoreCase(AUTHINFO_PARAM_PASS)" (line 575) seemed to
solve this problem.

Was there a reason why James wasn't already doing case insensitive
checking?  Should a new bug report be written for this?  I believe the
RFC indicates the commands should be case insensitive so I believe so
but wanted to check first.

Thanks,

Kevin



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to