> -----Original Message----- > From: Danny Angus [mailto:[EMAIL PROTECTED]] > Sent: 21 February 2003 14:05 > To: James Developers List > Subject: RE: Interesting code review of James > > > Jason, > > I use eclipse, and can also see quite a few unused imports, > but not a big proportion when compared to other Apache java > projects, and it's coming down. As far as the javadoc > problems you see, what are they? Some tools have a real > problem with "@" in javadoc comments outside tags, and others > complain for little or no perceptible reason about all kinds > of wierd stuff. In RemoteDelivery.java
* @param boolean permanent Not valid as it has a type declaration - you only need the param name There are also a few instances where params have been renamed in the code, but not in the javadoc I've got IntelliJ to do a full code inspection and I've published the results as HTML. They are on http://www.inovem.com/james/ as they are rather large. I don't personally agree with ALL the things that the inspection suggests. I think we have to apply judgement first. > > My guiding light in this is the output of j2sdk javadoc. IMO > if it doesn't complain, and the docs look right then they are > good enough. > > d. > > > > > -----Original Message----- > > From: Jason Webb [mailto:[EMAIL PROTECTED]] > > Sent: 21 February 2003 10:10 > > To: 'James Developers List' > > Subject: RE: Interesting code review of James > > > > > > I use IntelliJ as my Java IDE and it has a real problem > with some of > > the James JavaDoc, so I'm trying to correct them as I > submit patches. > > IntelliJ also highlights quite a few unused imports and > vars as well. > > I can't really give a nice report on these as they only > show up in the > > editor :( > > > > Lint for Java anyone? > > > > -- Jason > > > > > -----Original Message----- > > > From: Noel J. Bergman [mailto:[EMAIL PROTECTED]] > > > Sent: 21 February 2003 01:23 > > > To: James-Dev Mailing List > > > Subject: Interesting code review of James > > > > > > > > > http://cvs.apache.org/~tcopeland/pmdweb/james_jakarta-james.html > > > > > > > -------------------------------------------------------------------- > > > - > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
