Mark and Pierre,
I have committed a revision of AddFooter. This version appears to be
working properly based upon my tests with text/plain, text/html, and
multipart/alternative. I have put considerable debugging code into the
mailet, all commented out, to help track anymore issues as might come up.
NB: there is an issue with getRawInputStream, which I have also debugged.
We do not want to use it with JavaMail v1.3 if a message has changed.
One of the changes I made fixes a longstanding problem with text/html
footers being malformed.
Please review the changes at your leisure.
--- Noel
-----Original Message-----
From: Noel J. Bergman [mailto:[EMAIL PROTECTED]
Sent: Sunday, March 09, 2003 17:34
To: James Developers List
Subject: RE: [PATCH] AddFooter enhancement
Mark,
I am reviewing your submission. It appears that this also fixes the problem
that Pierre Scherer has been reporting.
One question. You removed the check for multipart/alternative as well as
adding the handling for MimeMultipart. Wasn't just the latter change
necessary, and shouldn't the former have been kept? For example, I don't
believe that you would want to run that loop on multipart/[related, signed,
encrypted, pgp, ...] parts.
Similarly, I'm wondering if the (part.getContent() instanceof MimeMultipart)
check ought to be a bit more selective.
Thoughts?
--- Noel
-----Original Message-----
From: Mark Imel [mailto:[EMAIL PROTECTED]
Sent: Friday, February 14, 2003 14:58
To: James Developers List
Subject: [PATCH] AddFooter enhancement
The current AddFooter mailet is unable to successfully add its footer to
more complex mail messages: specifically, any MimeMessage that has nested
MimeMultiparts.
These kinds of email messages may result when a user decides to use embedded
html elements with their email. For instance, Outlook Express has a
Stationary feature that causes these complex MimeMessages to occur.
I came across this scenario, while building a [slightly] more advanced list
serv mailet that i hope to donate either to mailet.org or the james project.
I wanted to embed a standard mailing list footer (like you see with the
Jakarta mailing lists), and ensure that the footer is included regardless of
the type of mail sent to the list.
Regards,
--mark imel
BTW: This is my first time submitting a patch to an apache project, i
apologize if i messed up the cvs diff file. I'd be more than happy to send
the modified AddFooter if preferred, or regenerate the diff file if
necessary.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
