Noel, > Welcome to one of my favorite James nightmares. I've made a > number changes > from Exception to Throwable becaue of RuntimeException.
This is a common nightmare also for me coding in Java; I always try to distinguish myself between coding errors throwing RuntimeException-s, "bad" events causing plain Exception-s and system errors causing Error-s; the problem is that foreign code can be not coherent. > > No, do not rename to onThrowable. Users don't make the distinction. > I agree :-). > Also please see: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18124 > > Are you sure about your assessment that the message is lost? I > looked over > that code before, and it seems to me that > JamesSpoolManager.process() would > leak the exception back to run(), where it would be caught. The message > would remain in the spool, the key would stay locked, and the > message would > be unavailable for processing. That might or might not be the desired > result in all cases, but the message would not be lost. No, the user (Oki DZ) didn't say anything about the outcome of the message. I just figured out that it was going nowhere; I understand that it is not totally lost, but remaining in the spool is somehow strange. I hope that you agree on my small fix. Let me know if you agree on doing the same for onException. Bye (I'm heading home now), Vincenzo --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
