> Currenlty Forward eats those non-ascii characters in the subject which are
> not in the default charset.
> The root of the problem is the same as was in GenericListserv.
(a) Would you like to submit a patch based upon your previous work?
> But this is more then a few lines and maybe it will be used
> in a third mailet, so it shouldn't be duplicated. Where
> should I put the common code?
IMO, you can submit it for AbstractRedirect. Eventually, I would expect
either to see more mailets that resend mail to inherit from
AbstractRedirect, or we'd refactor some of those field handling out of
AbstractRedirect into a common class.
(b) "The easiest workaround is to not change the subject, if not
necessary."
AbstractRedirect is in the process of being changed, as you know. It has
been setting values where there is no request to change a value, which is
redundant since we've already started with a clone. Vincenzo has already
changed some of that, and is still looking at the code to complete that
change. Your example, that if both <prefix> and <subject> are null, then
there is no need to touch the subject header, is a good one.
> I noticed that AbstractRedirect does use the empty string to indicate
> that no prefix was supplied. Shouldn't we change that to null, it
> seems to me that usually null is used in James for this?
I haven't looked at the original code, but the "" was probably for
convenience since "" + subject would always be a valid operation. I agree
with you that null for no change is probably the better choice, and
consistent with the newly recognized convention.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
