Thanks. It looks like the two header files in question were included in internal.h in FFmpeg 6.0.1 but were removed starting in FFmpeg 6.1, hence why you had a compilation issue but we didn't. I updated the patch: https://review.jami.net/c/jami-daemon/+/28348
Best, François-Simon ----- Original Message ----- From: "Maxim Cournoyer" <[email protected]> To: "François-Simon Fauteux-Chapleau" <[email protected]> Cc: "jami" <[email protected]>, "Sébastien Blin" <[email protected]> Sent: Wednesday, May 29, 2024 8:56:24 PM Subject: Re: [PATCH] contrib: Add missing includes to pipewiregrab patch. Hi, François-Simon Fauteux-Chapleau <[email protected]> writes: > Hi Maxim, > > Can you double-check that you're building against the right version of > FFmpeg? Jami currently uses 6.0.1. As far as I know, these includes are only > needed starting with version 7.0 (and indeed I already added them in the most > recent version of the patch submitted to FFmpeg: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240510211219.213409-1-francois-simon.fauteux-chapl...@savoirfairelinux.com/). > We do plan on upgrading to 7.0 at some point, we just haven't had the time > to do it yet. The ffmpeg version currently in use in Guix for the 'ffmpeg-jami' package is 6.1.1. -- Thanks, Maxim
