[John Keiser]
> In jnimeth.c, it looks like line 73 should say result.unionselector,

Hm, not in my source.  There the result is jtype, and gives correct
return type.

> or else the return value of the function should be jvalue.  I will
> not be modifying jnimeth.c at all for Classpath integration, so the
> fix should go in the main tree.  I don't know if this would cause
> any problems at all, but better safe than sorry.

Which version is this?

> Also, if you're interested, in libnative/java.lang.reflect, there is
> a serious error in invokeNative().  It does not handle void methods
> or methods that return primitive types correctly, instead simply
> using CallObjectMethod in all cases.  I assume you can see how
> easily this will cause segfaults.  This will be fixed in the
> Japhar+Classpath stuff, though, so unless you are desperate to get
> java.lang.reflect for Sun working right now, you may as well wait
> and copy stuff from my patch when it's done.

I'll have a look at this.

BTW: When is the estimated time of arrival for Classpath?  I try to
keep up-to-date with the CVS source, but has been unable to make a
working .class package.
-- 
##>  Petter Reinholdtsen <##    | [EMAIL PROTECTED]
 O-  <SCRIPT Language="Javascript">window.close()</SCRIPT>
http://www.hungry.com/~pere/    | Go Mozilla, go! Go!

Reply via email to