On Mon, May 25, 2009 at 10:26:10PM +0300, Pekka Enberg wrote: > Eduard - Gabriel Munteanu wrote: >> You can merge the first patch right away. > > Will do. > > Eduard - Gabriel Munteanu wrote: >> On the others I'd like your opinion. Are you okay with that >> '#include "emit-code.c"' stuff? > > Not really :-). Can't we just make the functions in emit-code.c non-static > and use them in the emit-code_32.c and emit-code_64.c? > > Pekka
Yes, we can, but I thought we unnecessarily end up with global symbols that we don't use in any other file. Apart from that, we need to create either a header file or declare prototypes in both emit-code_32.c and emit-code_64.c. I'll resubmit if you still don't like it :-). Eduard ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Jatovm-devel mailing list Jatovm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jatovm-devel