On Wed, 2009-06-24 at 22:21 +0200, Arthur HUILLET wrote:
> @@ -276,6 +277,121 @@ out:
> return err;
> }
>
> +static void assign_temporary(struct basic_block *bb, int entry, int slotnb,
> + struct var_info *tmp_high, struct var_info *tmp_low)
> +{
Indentation gone crazy in this function.
> + unsigned int i;
> + struct expression *expr;
> +
> + for (i = 0; i < bb->nr_mimic_stack_expr; i++) {
> + expr = bb->mimic_stack_expr[i];
> +
> + if (expr_type(expr) != EXPR_MIMIC_STACK_SLOT)
> + continue;
> +
> + if (expr->entry != entry ||
> + expr->slotnb != slotnb)
> + continue;
> +
> + expr_set_type(expr, EXPR_TEMPORARY);
> + expr->tmp_high = tmp_high;
> + expr->tmp_low = tmp_low;
> + }
> +}
> +static int __do_resolve_mimic_stack_slots(int nr_neighbors, struct
> basic_block **neighbors,
> + int entry)
> +{
The "__do" prefix makes no sense. The "__" is inherited from the kernel
and strictly speaking, we should not be using it in userspace. The "do"
prefix is what most people seem to do in userspace. But the combination
of the two is just... strange.
Anyway, I fixed it (and other goofs) up and applied the patch. Thanks!
------------------------------------------------------------------------------
_______________________________________________
Jatovm-devel mailing list
Jatovm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jatovm-devel
