2009/6/25 Vegard Nossum <vegard.nos...@gmail.com>: > 2009/6/25 Vegard Nossum <vegard.nos...@gmail.com> >> >> From bfe486f4c2463b319660931126f71f69b94ade21 Mon Sep 17 00:00:00 2001 >> From: Vegard Nossum <vegard.nos...@gmail.com> >> Date: Thu, 25 Jun 2009 15:21:01 +0200 >> Subject: [PATCH] build: fix long-standing bug with parallel make >> >> This got exposed with the recent cafebabe merge. We need to depend on >> monoburg getting built before we call it. >> >> Reported-by: Tomek Grabiec <tgrab...@gmail.com> >> Signed-off-by: Vegard Nossum <vegard.nos...@gmail.com> >> --- >> Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index f2da144..10cb05e 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -186,7 +186,7 @@ $(JAMVM_ARCH_H): >> $(E) " LN " $@ >> $(Q) ln -fsn ../../jamvm/arch/$(JAMVM_ARCH).h $@ >> >> -arch/$(ARCH)/insn-selector$(ARCH_POSTFIX).c: FORCE >> +arch/$(ARCH)/insn-selector$(ARCH_POSTFIX).c: monoburg FORCE >> $(E) " MONOBURG" $@ >> $(Q) $(MONOBURG) -p -e $(@:.c=.brg) > $@ > > Actually, this is wrong. We should depend on $(MONOBURG), no? > > Hmmr.
Actually, the other rules depend on "monoburg" as well, which is the directory. The directory's timestamp will get modified as well, when we output the monoburg/monoburg file. I don't really like it that much, but the original patch solves the problem and is in step with the rest of the Makefile. Vegard ------------------------------------------------------------------------------ _______________________________________________ Jatovm-devel mailing list Jatovm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jatovm-devel
