Author: veithen
Date: Sun Jan 20 13:31:15 2013
New Revision: 1435838

URL: http://svn.apache.org/viewvc?rev=1435838&view=rev
Log:
Some code simplifications.

Modified:
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/AckRequestedProcessor.java
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/MakeConnectionProcessor.java
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/AcknowledgementManager.java
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/RMMsgCreator.java
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SOAPFaultEnvelopeCreator.java
    
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SandeshaUtil.java

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/AckRequestedProcessor.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/AckRequestedProcessor.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/AckRequestedProcessor.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/AckRequestedProcessor.java
 Sun Jan 20 13:31:15 2013
@@ -51,7 +51,6 @@ import org.apache.sandesha2.util.Acknowl
 import org.apache.sandesha2.util.FaultManager;
 import org.apache.sandesha2.util.MsgInitializer;
 import org.apache.sandesha2.util.RMMsgCreator;
-import org.apache.sandesha2.util.SOAPAbstractFactory;
 import org.apache.sandesha2.util.SandeshaUtil;
 import org.apache.sandesha2.util.SpecSpecificConstants;
 import org.apache.sandesha2.util.WSRMMessageSender;
@@ -163,7 +162,7 @@ public class AckRequestedProcessor exten
                        ackMsgCtx.setMessageID(SandeshaUtil.getUUID());
                
                //adding the SOAP Envelope
-               SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil.getSOAPVersion(msgContext.getEnvelope()));
+               SOAPFactory factory = 
(SOAPFactory)msgContext.getEnvelope().getOMFactory();
                SOAPEnvelope envelope = factory.getDefaultEnvelope();
                try {
                        ackMsgCtx.setEnvelope(envelope);

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/MakeConnectionProcessor.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/MakeConnectionProcessor.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/MakeConnectionProcessor.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/msgprocessors/MakeConnectionProcessor.java
 Sun Jan 20 13:31:15 2013
@@ -53,7 +53,6 @@ import org.apache.sandesha2.storage.bean
 import org.apache.sandesha2.util.FaultManager;
 import org.apache.sandesha2.util.LoggingControl;
 import org.apache.sandesha2.util.MsgInitializer;
-import org.apache.sandesha2.util.SOAPAbstractFactory;
 import org.apache.sandesha2.util.SandeshaUtil;
 import org.apache.sandesha2.util.SpecSpecificConstants;
 import org.apache.sandesha2.workers.SandeshaThread;
@@ -369,15 +368,7 @@ public class MakeConnectionProcessor imp
        private static void addMessagePendingHeader(MessageContext 
returnMessage, String namespace) {
                MessagePending messagePending = new MessagePending();
                messagePending.setPending(true);
-               if (returnMessage.getEnvelope().getHeader() == null) {
-                       int SOAPVersion = Sandesha2Constants.SOAPVersion.v1_1;
-                       if (!returnMessage.isSOAP11())
-                               SOAPVersion = 
Sandesha2Constants.SOAPVersion.v1_2;
-                       //The header might not be there because of the 
persistence code if it doesn't exist we need to add one
-                       SOAPAbstractFactory.getSOAPFactory(
-                                       
SOAPVersion).createSOAPHeader(returnMessage.getEnvelope());
-               }
-               
messagePending.toHeader(returnMessage.getEnvelope().getHeader());
+               
messagePending.toHeader(returnMessage.getEnvelope().getOrCreateHeader());
        }
 
        public boolean processOutMessage(RMMsgContext rmMsgCtx, Transaction 
transaction) {

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/AcknowledgementManager.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/AcknowledgementManager.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/AcknowledgementManager.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/AcknowledgementManager.java
 Sun Jan 20 13:31:15 2013
@@ -201,7 +201,7 @@ public class AcknowledgementManager {
 
                ackMsgCtx.setMessageID(SandeshaUtil.getUUID());
 
-               SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil.getSOAPVersion(referenceMsg.getEnvelope()));
+               SOAPFactory factory = 
(SOAPFactory)referenceMsg.getEnvelope().getOMFactory();
 
                // Setting new envelope
                SOAPEnvelope envelope = factory.getDefaultEnvelope();

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/RMMsgCreator.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/RMMsgCreator.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/RMMsgCreator.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/RMMsgCreator.java
 Sun Jan 20 13:31:15 2013
@@ -454,7 +454,7 @@ public class RMMsgCreator {
                MessageContext outMessage = 
MessageContextBuilder.createOutMessageContext (requestMsg.getMessageContext());
                RMMsgContext responseRMMsg = new RMMsgContext(outMessage);
                
-               SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil.getSOAPVersion(requestMsg.getSOAPEnvelope()));
+               SOAPFactory factory = 
(SOAPFactory)requestMsg.getSOAPEnvelope().getOMFactory();
 
                String namespace = requestMsg.getRMNamespaceValue();
                responseRMMsg.setRMNamespaceValue(namespace);

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SOAPFaultEnvelopeCreator.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SOAPFaultEnvelopeCreator.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SOAPFaultEnvelopeCreator.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SOAPFaultEnvelopeCreator.java
 Sun Jan 20 13:31:15 2013
@@ -148,8 +148,7 @@ public class SOAPFaultEnvelopeCreator {
                        throw new 
SandeshaException(SandeshaMessageHelper.getMessage(
                                        SandeshaMessageKeys.soapEnvNotSet));
 
-               SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil
-                               .getSOAPVersion(faultMsgEnvelope));
+               SOAPFactory factory = 
(SOAPFactory)faultMsgEnvelope.getOMFactory();
 
                SOAPFault fault = faultMsgEnvelope.getBody().getFault();
 
@@ -182,8 +181,7 @@ public class SOAPFaultEnvelopeCreator {
                        throw new 
SandeshaException(SandeshaMessageHelper.getMessage(
                                        SandeshaMessageKeys.soapEnvNotSet));
 
-               SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil
-                               .getSOAPVersion(faultEnvelope));
+               SOAPFactory factory = (SOAPFactory)faultEnvelope.getOMFactory();
 
                SOAPFault fault = faultEnvelope.getBody().getFault();
                if (fault == null)

Modified: 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SandeshaUtil.java
URL: 
http://svn.apache.org/viewvc/axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SandeshaUtil.java?rev=1435838&r1=1435837&r2=1435838&view=diff
==============================================================================
--- 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SandeshaUtil.java
 (original)
+++ 
axis/axis2/java/sandesha/trunk/modules/core/src/main/java/org/apache/sandesha2/util/SandeshaUtil.java
 Sun Jan 20 13:31:15 2013
@@ -430,8 +430,7 @@ public class SandeshaUtil {
                        operationContext.addMessageContext(newMessageContext);
 
                        // adding a blank envelope
-                       SOAPFactory factory = 
SOAPAbstractFactory.getSOAPFactory(SandeshaUtil.getSOAPVersion(referenceMessage
-                                       .getEnvelope()));
+                       SOAPFactory factory = 
(SOAPFactory)referenceMessage.getEnvelope().getOMFactory();
                        
newMessageContext.setEnvelope(factory.getDefaultEnvelope());
 
                        
newMessageContext.setTransportIn(referenceMessage.getTransportIn());


Reply via email to