This is an automated email from the ASF dual-hosted git repository. robertlazarski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/axis-axis2-java-core.git
commit a11c41231ebfda03f3b6f07a73d80f4d570ad7ff Author: Robert Lazarski <[email protected]> AuthorDate: Mon May 11 17:29:43 2026 -1000 docs: Remove proprietary references from pagination code and docs - Replace AssetBO/AssetQuery with generic Product/ProductQuery in Javadoc examples and xdoc documentation - Remove SmartClient references from Javadoc, doc, and test comments; use generic "data grid" instead - Rename "SmartClient startRow/endRow" section to "Grid startRow/endRow Translation" Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> --- .../src/org/apache/axis2/json/rpc/PaginatedResponse.java | 6 +++--- .../org/apache/axis2/json/rpc/PaginatedResponseTest.java | 2 +- src/site/xdoc/docs/json-pagination.xml | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/json/src/org/apache/axis2/json/rpc/PaginatedResponse.java b/modules/json/src/org/apache/axis2/json/rpc/PaginatedResponse.java index a8491b1e65..65c32de4b0 100644 --- a/modules/json/src/org/apache/axis2/json/rpc/PaginatedResponse.java +++ b/modules/json/src/org/apache/axis2/json/rpc/PaginatedResponse.java @@ -52,7 +52,7 @@ import java.util.List; * Cursor pagination requires a stable sort key and stateful server-side * tokens — added complexity with no benefit when the underlying query is * already offset-based.</li> - * <li>Frontend grids (SmartClient, AG Grid, React Table) natively speak + * <li>Frontend grids (AG Grid, React Table, etc.) natively speak * offset/limit via {@code startRow}/{@code endRow} or * {@code page}/{@code pageSize}. Cursor tokens require client-side * adaptation.</li> @@ -64,8 +64,8 @@ import java.util.List; * * <h3>Usage in a service method</h3> * <pre>{@code - * public PaginatedResponse<AssetBO> findAssets(AssetQuery query) { - * List<AssetBO> items = dao.findList(query.getOffset(), query.getLimit()); + * public PaginatedResponse<Product> findProducts(ProductQuery query) { + * List<Product> items = dao.findList(query.getOffset(), query.getLimit()); * long total = dao.count(query); * return PaginatedResponse.of(items, query.getOffset(), query.getLimit(), total); * } diff --git a/modules/json/test/org/apache/axis2/json/rpc/PaginatedResponseTest.java b/modules/json/test/org/apache/axis2/json/rpc/PaginatedResponseTest.java index 6dc08ef38e..660970dc3d 100644 --- a/modules/json/test/org/apache/axis2/json/rpc/PaginatedResponseTest.java +++ b/modules/json/test/org/apache/axis2/json/rpc/PaginatedResponseTest.java @@ -270,7 +270,7 @@ public class PaginatedResponseTest { @Test public void testEnterprise_virtualScroll_startRowEndRow() { - // Scenario: SmartClient-style grid sends startRow=300, endRow=350. + // Scenario: data grid sends startRow=300, endRow=350. // The service translates: offset = startRow, limit = endRow - startRow. int startRow = 300; int endRow = 350; diff --git a/src/site/xdoc/docs/json-pagination.xml b/src/site/xdoc/docs/json-pagination.xml index 5a09d5aeb7..1f6c13fc06 100644 --- a/src/site/xdoc/docs/json-pagination.xml +++ b/src/site/xdoc/docs/json-pagination.xml @@ -63,8 +63,8 @@ map directly to JPA/Hibernate's <code>setFirstResult(offset)</code> and <p>A typical service method delegates offset/limit to the DAO:</p> <pre> -public PaginatedResponse<AssetBO> findAssets(AssetQuery query) { - List<AssetBO> items = dao.findList(query.getOffset(), query.getLimit()); +public PaginatedResponse<Product> findProducts(ProductQuery query) { + List<Product> items = dao.findList(query.getOffset(), query.getLimit()); long total = dao.count(query); return PaginatedResponse.of(items, query.getOffset(), query.getLimit(), total); } @@ -132,9 +132,9 @@ if (pagination.hasMore) { } </pre> -<h3>SmartClient startRow/endRow</h3> +<h3>Grid startRow/endRow Translation</h3> <pre> -// SmartClient sends startRow=300, endRow=350 +// Grid sends startRow=300, endRow=350 // Service translates: offset = startRow, limit = endRow - startRow int offset = startRow; int limit = endRow - startRow; @@ -146,7 +146,7 @@ int limit = endRow - startRow; <li><strong>DAO compatibility</strong> — existing Hibernate/JPA DAOs use <code>query.setFirstResult(offset)</code> and <code>query.setMaxResults(limit)</code>. Cursor pagination requires a stable sort key and stateful server-side tokens.</li> - <li><strong>Frontend grids</strong> — SmartClient, AG Grid, and React Table natively + <li><strong>Frontend grids</strong> — data grids (AG Grid, React Table, etc.) natively speak offset/limit via <code>startRow</code>/<code>endRow</code> or <code>page</code>/<code>pageSize</code>.</li> <li><strong>totalCount</strong> — enables "Showing 1–50 of 1,247" UI patterns @@ -164,7 +164,7 @@ int limit = endRow - startRow; <li>Unpaginated convenience factory</li> <li>Negative offset clamping, zero/negative limit defaults, maxLimit enforcement</li> <li>Enterprise scenarios: 8,543-item virtual scroll, soft-delete filtering, - service-specific maxLimit, SmartClient startRow/endRow translation</li> + service-specific maxLimit, grid startRow/endRow translation</li> <li>Request → response round-trip simulation</li> </ul>
